Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qrcode bitmap endpoint for last unused address #23

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

lvaccaro
Copy link
Owner

Draft proposal to add /bitcoin/api/last_unused_qr.bmp endpoint for returning a qr code bitmap of your last unused address.
From thunderbiscuit request: #14 (comment) .

src/html.rs Outdated
@@ -67,7 +67,7 @@ pub fn to_data_url<T: AsRef<[u8]>>(input: T, content_type: &str) -> String {
}

/// Creates QR containing `message` and encode it in data url
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs need update

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks update docs

src/html.rs Outdated
Ok(cursor.into_inner())
}

pub fn create_bmp_base64_qr(message: &str) -> Result<String, std::io::Error> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pub not needed here

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks fixed

@RCasatta
Copy link
Collaborator

Ack

@lvaccaro lvaccaro merged commit c2d3204 into master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants