Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign quick view to be a provider and use query params #1133

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

factoidforrest
Copy link
Contributor

This is the CORRECT implementation of the quick-view system, that I should have written from the start.

The two main changes are:

  • to use a provider to hold this state instead of the gnarly prop drilling.
  • to use the query string in the URL to track the quick view state. Really nice because people can link to quick views now.

This was needed before we started porting quick view to other parts of the app, as is planned for vuln search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants