Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create initial pinata implementation. Pinata has different apis node/browser due to FormData #222

Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

richtera
Copy link
Contributor

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Initial implementation of more generic uploader and URL converter
Implement first ifps-http-client
Implement second pinata
Show example implementation of new upload provider

  • fix: Refactor pinata and ipfs providers/url-converters
  • fix: More work. Testing in jest/dom vs jest/node is needed. Apis for pinata are not the same

@richtera richtera force-pushed the fix/refactor-to-callback branch 2 times, most recently from b4919b6 to 311d4b4 Compare October 6, 2023 16:26
@richtera richtera marked this pull request as ready for review October 10, 2023 10:48
@richtera richtera marked this pull request as draft October 11, 2023 19:22
@richtera
Copy link
Contributor Author

Converting this to draft. Due to signer/nonce the test scripts are flaky.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #222 (c0daef2) into develop (ca39a3a) will increase coverage by 64.86%.
The diff coverage is 60.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##           develop     #222       +/-   ##
============================================
+ Coverage    19.60%   84.47%   +64.86%     
============================================
  Files           15       19        +4     
  Lines         1066     1172      +106     
  Branches       373      356       -17     
============================================
+ Hits           209      990      +781     
+ Misses         834      160      -674     
+ Partials        23       22        -1     
Files Coverage Δ
src/lib/classes/lsp7-digital-asset.ts 97.22% <100.00%> (+78.07%) ⬆️
src/lib/classes/lsp8-identifiable-digital-asset.ts 97.22% <100.00%> (+78.07%) ⬆️
src/lib/helpers/config.helper.ts 100.00% <ø> (ø)
src/lib/services/base-contract.service.ts 98.85% <100.00%> (+91.44%) ⬆️
src/lib/services/universal-receiver.service.ts 100.00% <100.00%> (+76.66%) ⬆️
src/lib/helpers/deployment.helper.ts 95.31% <93.33%> (+73.18%) ⬆️
src/lib/services/key-manager.service.ts 97.29% <75.00%> (+80.15%) ⬆️
src/lib/providers/url-converter.ts 90.00% <90.00%> (ø)
src/lib/classes/lsp4-digital-asset-metadata.ts 71.42% <72.72%> (+63.09%) ⬆️
src/lib/classes/universal-profile.ts 80.88% <64.28%> (+66.06%) ⬆️
... and 7 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@richtera richtera marked this pull request as ready for review October 12, 2023 19:41
@richtera
Copy link
Contributor Author

@CallumGrindle I had to disable the JWT test, because it now depends on GCP KMS being available in github actions.

@richtera richtera marked this pull request as draft October 18, 2023 17:49
@richtera
Copy link
Contributor Author

We're going to push a bunch of the IPFS stuff into erc725 and leave the jest and so fixes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants