Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace result '0' when checking for card permissions with a message … #15

Closed
wants to merge 1 commit into from
Closed

Replace result '0' when checking for card permissions with a message … #15

wants to merge 1 commit into from

Conversation

jasiek
Copy link
Contributor

@jasiek jasiek commented Sep 9, 2015

Don't merge yet, I'm looking for feedback.

The idea behind this change is to enable two new scenarios for acnode:

  1. to be used as a doorbot replacement
  2. to be used in audit-only mode (where any valid card permits you to use a tool).

@jasiek
Replace result '0' when checking for card permissions with a message …
2e95b8b 
…indicating whether

this is a known or an unknown card.
@JasperWallace
Copy link
Member

Can we just do it with numbers? See issue #6 where -1 in unknown card and 0 is hackspace member, but not authorised.

@jasiek
Copy link
Contributor Author

jasiek commented Sep 10, 2015

Yeah, that makes sense.

@jasiek jasiek closed this Sep 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasiek @JasperWallace