Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome cache payloads #4696

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chb2mn
Copy link
Contributor

@chb2mn chb2mn commented Jun 21, 2023

One line description of pull request

Chrome:cache:entry events only consist of url + time. I wanted to add some richness to that

Description:

I wanted to include some information about the actual payload in the cache. So this includes human-readable information about the datastream(s) behind an entry. The data streams are either internal (data_N (offset: 0x123456)) or external (f_012345).

Notes:

@joachimmetz I wanted your opinion on how to format the payload. Right now it's just a json.dumps(my_list), but there's probably a more elegant way of adding the info to the event.

Checklist:

  • Automated checks (GitHub Actions, AppVeyor) pass
  • No new new dependencies are required or l2tdevtools has been updated
  • Reviewer assigned

@chb2mn chb2mn changed the title Chrome cache payloads Draft: Chrome cache payloads Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12% ⚠️

Comparison is base (d6022f8) 86.12% compared to head (7a19acc) 86.01%.

❗ Current head 7a19acc differs from pull request most recent head d708c55. Consider uploading reports for the commit d708c55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4696      +/-   ##
==========================================
- Coverage   86.12%   86.01%   -0.12%     
==========================================
  Files         416      416              
  Lines       37446    37344     -102     
==========================================
- Hits        32252    32123     -129     
- Misses       5194     5221      +27     
Files Changed Coverage Δ
plaso/parsers/chrome_cache.py 81.98% <100.00%> (+1.98%) ⬆️

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chb2mn chb2mn changed the title Draft: Chrome cache payloads Chrome cache payloads Jun 26, 2023
@joachimmetz joachimmetz self-assigned this Aug 26, 2023
@joachimmetz
Copy link
Member

@chb2mn must have missed this earlier, looks like this PR has a merge conflict This branch has conflicts that must be resolved could you PTAL. I'll try to have a closer look at the PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants