Fix: reset password namespace & start chart name #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
neogopher
approved these changes
Sep 11, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Sep 11, 2024
[v0.20] Merge pull request #2132 from FabianKramm/main
| parsedVersion, err := semver.Parse(strings.TrimPrefix(cmd.Version, "v")) | ||
| if err != nil { | ||
| return fmt.Errorf("parse provided version %s: %w", cmd.Version, err) | ||
| } else if parsedVersion.LT(semver.MustParse("4.0.0-alpha.0")) && cmd.ChartName == "vcluster-platform" { |
There was a problem hiding this comment.
Why is this hard-coded?
Upgraded platforms will still have loft, but only fresh installs will have vcluster-platform.
Also, users could choose any namespace name that they want.
There was a problem hiding this comment.
This is not about the namespace its the chart that doesn't exist prior to v4.0.0-alpha.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix