Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error logging around attempting to open browser #2122

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

rohantmp
Copy link
Contributor

@rohantmp rohantmp commented Sep 9, 2024

part of ENG-4327
image
image

@rohantmp rohantmp marked this pull request as draft September 9, 2024 08:35
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for vcluster-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ba86770
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66deb337f7e82a0008c59bfc
😎 Deploy Preview https://deploy-preview-2122--vcluster-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohantmp rohantmp marked this pull request as ready for review September 9, 2024 08:47
@FabianKramm FabianKramm merged commit 478ff1e into loft-sh:main Sep 9, 2024
61 checks passed
@rohantmp rohantmp added the backport-to-v0.20 backport this PR to v0.20 branch label Sep 10, 2024
@loft-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v0.20

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

FabianKramm added a commit that referenced this pull request Sep 10, 2024
[v0.20] Merge pull request #2122 from rohantmp/fixBrowerLog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.20 backport this PR to v0.20 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants