(capi): remove vcluster default version #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narcis96
force-pushed
the
narcis/capi_followup_1
branch
2 times, most recently
from
b137a8e
to
4bcec82
Compare
johannesfrey
reviewed
Apr 4, 2024
api/v1alpha1/vcluster_types.go
Outdated
| VirtualClusterSpec VirtualClusterSpec `json:"virtualClusterSpec,omitempty"` | ||
| } | ||
|
|
||
| type VirtualClusterSpec struct { |
There was a problem hiding this comment.
Could Version and Image also be directly inside VClusterSpec? IMHO it feels a bit like a duplicate to have a VirtualClusterSpec inside the VClusterSpec.
johannesfrey
reviewed
Apr 4, 2024
narcis96
force-pushed
the
narcis/capi_followup_1
branch
6 times, most recently
from
b344ee7
to
1c6e70f
Compare
narcis96
force-pushed
the
narcis/capi_followup_1
branch
from
1c6e70f
to
73a60f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref ENG-3153