Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console.log calls #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

westonganger
Copy link
Contributor

No description provided.

@did
Copy link
Member

did commented May 29, 2019

instead of removing them, why not commenting them once generated? Free to the developers to uncomment them. Any thoughts @westonganger and @manuchap?

@westonganger
Copy link
Contributor Author

I would prefer either:

A. commented out by default
B. wrap them in an if(!production) call

@manuchap
Copy link
Contributor

Sry, I removed my previous comment which was irrelevant/unclear (which happens often 🙃).
The if(!production) option seems legit.
I was just afraid to see them disappear since I've limited coding skill and to me every log is a good log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants