Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let LiveReloadPlugin handle the script in the page's head #368

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Let LiveReloadPlugin handle the script in the page's head #368

wants to merge 26 commits into from

Conversation

manuchap
Copy link
Contributor

Use case: Pages not using the default layout.

Include livereload script in head
removed live reload script which is added by the plugin
@did
Copy link
Member

did commented May 27, 2019

good one @manuchap. Could you also please update the following file too?
https://github.com/locomotivecms/wagon/blob/master/generators/blank/app/assets/webpack.common.js
Thanks!

append LR script in page's head
@manuchap
Copy link
Contributor Author

Done :-)

@did
Copy link
Member

did commented May 29, 2019

@manuchap let me know when you'll be done ;-)

@manuchap
Copy link
Contributor Author

manuchap commented May 29, 2019

😅 Tried to do separate pull requests for live reload and script loader (which was commented out as a bonus) but I guess I can't.
I've kept the edit though in webpack.prod.js that was calling the wrong file.
Tell me if I should remove it too.

The presets definition needs to be an array in order to deploy without errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants