Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to symmetric decryption #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes to symmetric decryption #377

wants to merge 1 commit into from

Conversation

einarmo
Copy link
Contributor

@einarmo einarmo commented Aug 21, 2024 •
edited
Loading

Remove padding when decrypting symmetric messages.

Also fixes a pair of minor issues:

  • We stored the session ID before actually validating that we got a valid session. This stuff can still be improved, but this at least fixes an obvious hole.
  • 2^13 is 8192, not 8196, this is also what the standard uses.

Should fix #373

@einarmo einarmo mentioned this pull request Aug 21, 2024
Open
@DOhlsson
Copy link

I tried running with the code in this branch but got the error I posted about here

@DOhlsson
Copy link

I tried running with the code in this branch but got the error I posted about here

That was an unrelated issue. This PR solves the actual problem I was having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AiyionPrime AiyionPrime AiyionPrime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opcua client fails to connect to Prosys Simulation Server configured with multiple endpoints
3 participants
@einarmo @DOhlsson @AiyionPrime