Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora build adjustments #95

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fedora build adjustments #95

wants to merge 4 commits into from

Conversation

raag
Copy link

@raag raag commented May 7, 2022

Hello I made some adjustments to be able to compile in fedora, there's only some changes in CMakeLists to look for the libraries in the correct directories and the instructions with dependencies in README file.

@raag raag mentioned this pull request May 7, 2022
@sugamkarki
Copy link

Works perfectly with Fedora 36. Thanks mate!

README.md Outdated Show resolved Hide resolved
@torvitas
Copy link

Just tried that on fedora 36 as well. Works like a charm. Thanks a lot!

@samson7point1
Copy link

Also confirming these instructions work great on Fedora 36. Thanks!

@T0MASD
Copy link
Contributor

T0MASD commented Aug 23, 2022

confirming plugin builds on fedora 36

$ cmake -DLIBOBS_INCLUDE_DIR=/usr/share/obs/libobs -DEXTRA_LIBRARY_PATH=/usr/include/obs -DWITH_CUDA=ON .. && cmake --build . && sudo cmake --install .
-- Found Git: /usr/bin/git (found version "2.37.2") 
-- The C compiler identification is GNU 12.1.1
-- The CXX compiler identification is GNU 12.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Onnxruntime: /usr/local/include  
-- Found OpenCV: /usr (found suitable version "4.5.5", minimum required is "4.5") found components: core imgproc 
-- Configuring done
-- Generating done
-- Build files have been written to: /home/tomas/build/obs-backgroundremoval-fedora/build
[ 33%] Building CXX object CMakeFiles/obs-backgroundremoval.dir/src/background-filter.cpp.o
[ 66%] Building CXX object CMakeFiles/obs-backgroundremoval.dir/src/plugin-main.cpp.o
[100%] Linking CXX shared module obs-backgroundremoval.so
[100%] Built target obs-backgroundremoval
-- Install configuration: ""
-- Installing: /usr/local/lib64/obs-plugins/obs-backgroundremoval.so
-- Set runtime path of "/usr/local/lib64/obs-plugins/obs-backgroundremoval.so" to ""
-- Installing: /usr/local/share/obs/obs-plugins/obs-backgroundremoval/locale/en-US.ini
-- Installing: /usr/local/share/obs/obs-plugins/obs-backgroundremoval/SINet_Softmax_simple.onnx
-- Installing: /usr/local/share/obs/obs-plugins/obs-backgroundremoval/mediapipe.onnx
-- Installing: /usr/local/share/obs/obs-plugins/obs-backgroundremoval/modnet_simple.onnx
-- Installing: /usr/local/share/obs/obs-plugins/obs-backgroundremoval/rvm_mobilenetv3_fp32.onnx
-- Installing: /usr/local/share/obs/obs-plugins/obs-backgroundremoval/selfie_segmentation.onnx

plugin is loaded when starting obs

info: [obs-backgroundremoval] plugin loaded successfully (version 0.4.0)

ping @royshil

@ClifHouck
Copy link

Worked for me as well, thank you!

@raag
Copy link
Author

raag commented Sep 22, 2022

Worked for me as well, thank you!

Great

@royshil
Copy link
Collaborator

royshil commented Mar 8, 2023

is anyone from the contributor team ready to merge/rebase on main and bring this up in CI?

@umireon
Copy link
Member

umireon commented May 31, 2023

I think the current version can be built on Fedora without modification and thus we can close this PR as already implemented.
We still need concise documentation for Fedora but it can be handled within another PR.

@umireon
Copy link
Member

umireon commented May 31, 2023

@royshil Can we close this PR as completed?

@jagg2
Copy link

jagg2 commented Jun 24, 2023

Can confirm that the version as of 2023-04-23(db8791a) (been meaning to make this comment for a while) does build on fedora 37, however the build script needs to be updated todo so.
I've published my changes that got it to work here: jagg2@8c9f7ee
However i'm not sure if this is the best solution, (hence why i'm not making a PR) but might be a good starting point for someone else looking todo a fedora build.

notes:
uses the git build of obs, and will cause problems with any existing obs on the system. (flatpak, .rpm)
doesn't create an .rpm package. need to manually copy the files to install. recommend referring to the .deb structure

@umireon
Copy link
Member

umireon commented Jun 25, 2023

@jagg2
We would not fix the build scripts because the Fedora distribution of OBS is not official but will provide some documentation to use CMake directly.
And I am planning to provide rpm on Packman.
Does this make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants