Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename file to built as a partial #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update and rename file to built as a partial #199

wants to merge 1 commit into from

Conversation

nico01f
Copy link

@nico01f nico01f commented Feb 20, 2022 •
edited
Loading

Don't recognize .js.erb file when is request shown the comments threads.
I change the filename and include <script> tag to act as .js file

ActionView::Template::Error (Missing partial commontator/threads/_hide_show_links with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby]}.

Searched in:
  * "/home/nicof/Documents/projects/rails/rateMyIdea/app/views"
  * "/home/nicof/.asdf/installs/ruby/3.0.2/lib64/ruby/gems/3.0.0/gems/avo-1.17.1/app/views"
  * "/home/nicof/.asdf/installs/ruby/3.0.2/lib64/ruby/gems/3.0.0/gems/view_component-2.47.0/app/views"
  * "/home/nicof/.asdf/installs/ruby/3.0.2/lib64/ruby/gems/3.0.0/gems/devise-4.8.1/app/views"
  * "/home/nicof/.asdf/installs/ruby/3.0.2/lib64/ruby/gems/3.0.0/gems/commontator-7.0.0/app/views"
  * "/home/nicof/.asdf/installs/ruby/3.0.2/lib64/ruby/gems/3.0.0/gems/actionmailbox-7.0.0/app/views"
):
    110: </div>
    111: 
    112: <script type="text/javascript">
    113:   <%= render partial: 'commontator/threads/hide_show_links', locals: { thread: thread } %>
    114: </script>

Not the most polite to do so, but it's simply and just works.

@nico01f
Update and rename file to built as a partial
b2efed2 
Don't recognize .js.erb file when is request shown the comments threads.
I change the filename and include <script> tag to act as .js file

ActionView::Template::Error (Missing partial commontator/threads/_hide_show_links with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby]}.

Not the most polite to do so, but it's simply and just works.
@Dantemss
Copy link
Member

Dantemss commented Aug 1, 2023

I think you'd have to modify the file that includes this too to remove the duplicate script tag.

Dantemss
Dantemss requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Dantemss Dantemss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dantemss Dantemss Dantemss requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nico01f @Dantemss