fix(Android): AAC duration can not be obtained.

llfbandit · Dec 14, 2023 · dce6da2 · dce6da2
1 parent 7d2ddb6
commit dce6da2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/record_android/CHANGELOG.md b/record_android/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 1.0.4
+* fix: AAC duration can not be obtained.
+
 ## 1.0.3
 * fix: Stop method returns before recording being actually finished.
 * fix: Changing config is not taken into account when reusing same instance.

diff --git a/..._android/android/src/main/kotlin/com/llfbandit/record/record/encoder/MediaCodecEncoder.kt b/..._android/android/src/main/kotlin/com/llfbandit/record/record/encoder/MediaCodecEncoder.kt
@@ -54,26 +54,28 @@ class MediaCodecEncoder(
     }
 
     private fun createCodec(mediaFormat: MediaFormat): MediaCodec {
-        val isSdk28OrBelow = android.os.Build.VERSION.SDK_INT <= android.os.Build.VERSION_CODES.P
-        var encoder = if (isSdk28OrBelow) MediaCodecList(MediaCodecList.REGULAR_CODECS).findEncoderForFormat(mediaFormat)
-                      else findCodecForFormat(mediaFormat)
-                      ?: throw Exception("No encoder found for $mediaFormat")
+        val encoder = if (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q) {
+            MediaCodecList(MediaCodecList.REGULAR_CODECS).findEncoderForFormat(mediaFormat)
+        } else {
+            findCodecForFormat(mediaFormat)
+        }
 
-        val codec = MediaCodec.createByCodecName(encoder)
+        encoder ?: throw Exception("No encoder found for $mediaFormat")
 
+        var mediaCodec: MediaCodec? = null
         try {
-            codec.configure(mediaFormat, null, null, MediaCodec.CONFIGURE_FLAG_ENCODE)
+            mediaCodec = MediaCodec.createByCodecName(encoder)
+            mediaCodec.configure(mediaFormat, null, null, MediaCodec.CONFIGURE_FLAG_ENCODE)
+            return mediaCodec
         } catch (e: Exception) {
-            codec.release()
+            mediaCodec?.release()
             throw e
         }
-
-        return codec
     }
 
     private fun internalStop() {
         codec.stop()
-        container.stop()
+
         listener.onEncoderStop()
     }
 

diff --git a/record_android/pubspec.yaml b/record_android/pubspec.yaml
@@ -1,6 +1,6 @@
 name: record_android
 description: Android specific implementation for record package called by record_platform_interface.
-version: 1.0.3
+version: 1.0.4
 homepage: https://github.com/llfbandit/record/tree/master/record_android
 
 environment: