Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable win32 #7

Open
wants to merge 18 commits into
base: unstable
Choose a base branch
from
Open

Unstable win32 #7

wants to merge 18 commits into from

Conversation

Corion
Copy link

@Corion Corion commented Feb 12, 2012

These are my changes to make siftmatch.exe build on Windows mingw gcc 4.4.1.

These changes are ugly, especially the make.bat things I did. I plan to add a proper Makefile once I get the build somewhat stabilized.

@liuliu
Copy link
Owner

liuliu commented Feb 13, 2012

Hi, thanks for the pull request, I am more interested in the script that compiles with windows, can you elaborate on that? I have tried to fix the memory access error in sift, please checkout the my new commit (b3591e0) and see if that fix the problem, thanks!

@Corion
Copy link
Author

Corion commented Feb 13, 2012

There are now new commits adding "makefile.mk" for bin/ and lib/ , which do build the library and programs using dmake.exe on Windows. There were very little changes needed, mostly in the files included.he two relevant patches are e4dce69 and 0472e6f I think.

@liuliu
Copy link
Owner

liuliu commented Apr 4, 2012

Sorry that recently I am pushing some aggressive changes in APIs and code structure in general that potentially could break this pull request. After I finished dpm and a few touches in bbf, there will finally be a tagged 0.1 version, could you modify this pull request by then? Thanks!

@Corion
Copy link
Author

Corion commented Apr 7, 2012

Hello,

Am 05.04.2012 01:39, schrieb Liu Liu:

Sorry that recently I am pushing some aggressive changes in APIs and code structure in general that potentially could break this pull request. After I finished dpm and a few touches in bbf, there will finally be a tagged 0.1 version, could you modify this pull request by then? Thanks!

I've rebased my branch request onto your changes. I'll withdraw this
pull request and send a fresh one for the rebased branch.

-max

@Corion
Copy link
Author

Corion commented Apr 7, 2012

OK - closing the pull request didn't work out, but I was able to update the commit range. This branch should (currently) merge without problems into your unstable branch. If you don't want to merge it now, I'll rebase again later - no need to hurry.

@Corion Corion closed this Apr 7, 2012
@Corion Corion reopened this Apr 7, 2012
@liuliu
Copy link
Owner

liuliu commented Jul 2, 2012

Hi, since 0.1 is out, if you are still interested in this, could you patch stable/r0.1-rc1 branch with Win32 compilation support? That will be a great help!

@Corion
Copy link
Author

Corion commented Jul 3, 2012

Hello,

Hi, since 0.1 is out, if you are still interested in this, could you
patch stable/r0.1-rc1 branch with Win32 compilation support? That
will be a great help!

Yes, I'm still interested! I'm just really busy currently, so I don't
know if I can submit a patch-branch before end of this week. The main
meat of my change is to guard against #include <malloca.h> on Win32 in
lib/ccv.h:

+#ifndef _MSC_VER
#include <unistd.h>
#include <stdint.h>
+#endif
...
+#ifdef _WIN32
+#include <malloc.h>
+#else
#include <alloca.h>
+#endif

But I need some time to do an actual diff between my git-tree for the
Perl bindings at https://github.com/Corion/image-ccv/ (in the directory
ccv-lib) and your source.

-max

@mhm0902
Copy link

mhm0902 commented Jan 18, 2013

在windows下运行,训练出来的分类器,读取有问题。
需要转换。

@bompus
Copy link

bompus commented Apr 19, 2013

Any chance on getting these merged with a tutorial on how to compile on Win32? Ideally with Visual Studio (C++) 2012.

Thank you!

@Corion
Copy link
Author

Corion commented Sep 7, 2013

I just saw your request - sorry for not reacting sooner :-/

I don't use Visual Studio, so I can't be of help here, sorry. I only use the MinGW gcc compiler, and that only because it's included with Strawberry Perl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants