added interface to set fpRate #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpRate: false positive rate for the bloomfilter
|
ugh...no looks. I need to merge. Its been 3 days. |
|
@kcw-grunt Sorry, I just opened it. You are doing great. Btw, I have questions, what are BRSetApply, BRSetClear, BRAddress? |
kcw-grunt
added a commit
that referenced
this pull request
Mar 29, 2023
* typo :) * va_list include * enable ipv6 * default to ipv6 and fallback to ipv4 * fix ipv4 fallback * Increase MAX_FEE_PER_KB * Fix 0 change output * sha3-256 and keccak-256 * const keywords * update tx ordering on confirmation * compiler warnings * Litecoin: params * Litecoin: scrypt pow & max_proof_of_work * Litecoin: disable retarget check * Litecoin: add new checkpoint * BIP39_CREATION_TIME -> LoafWallet release date * update secp * make sure to call balanceChanged callback whenever balance is updated * Change bitcoin-testnet with litecoin-testnet * bech32: update files * add missing files * add BRPeerManagerStandardPort method which returns the standard port used for chain params * 🦺Updated the checkpoints: Android branch (#24) * Updated the checkpoints * only 1 checkpoint added * Added Testnet checkpoint * added interface to set fpRate (#28) fpRate: false positive rate for the bloomfilter * fixed the signature (#29) --------- Co-authored-by: LiteBit <[email protected]> Co-authored-by: Aaron Voisine <[email protected]> Co-authored-by: Adrian Corscadden <[email protected]> Co-authored-by: Luca Vaccaro <[email protected]> Co-authored-by: Loshan T <[email protected]> Co-authored-by: Mohamed Barry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allows the user to chose a fp for the bloom filter
Closes
#27