run jenkins-builder as local only, fix deprecation, hardcode for s6v3, restructure templating #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aptalca
commented
Feb 22, 2024
•
aptalca
commented
- Run jenkins-builder as local only (1st step to removing the remote run steps that double the number of tasks, consistent behavior between local and ci, much easier to test and troubleshoot) 6a50b4f
- Second step of removing the remote run steps would likely have to be done after all repos are updated otherwise jenkins build will fail running on an older Jenkinsfile. In such cases, a local update of templates pushed to github should fix it
- Fix deprecation (s6v2 vs s6v3 detection was working on a local run, but failing on remote. This PR hardcodes it to s6v3) 6a50b4f
- Increase verbosity of templating steps 0719f3e
- Slightly restructure templating to prevent a potential race condition by ensuring each commit to main repo results in an immediate build exit as the commit will trigger a new build and we don't want simultaneous builds running 0719f3e
Prevent potential race condition by ensuring each commit to main repo results in an immediate build exit as the commit will trigger a new build and we don't want simultaneous builds running
|
I am a bot, here are the test results for this PR:
|
Roxedus
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.