Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unraid env options #67

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Add unraid env options #67

merged 1 commit into from
Nov 19, 2023

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Nov 19, 2023

No description provided.

Signed-off-by: Eric Nemchik <[email protected]>
@nemchik nemchik requested a review from a team November 19, 2023 01:06
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duckdns/e48542ca-pkg-e48542ca-dev-8c36a7a608c56c8b6c9533d9d2cfe212516f0023-pr-67/index.html
https://ci-tests.linuxserver.io/lspipepr/duckdns/e48542ca-pkg-e48542ca-dev-8c36a7a608c56c8b6c9533d9d2cfe212516f0023-pr-67/shellcheck-result.xml

Tag Passed
amd64-e48542ca-pkg-e48542ca-dev-8c36a7a608c56c8b6c9533d9d2cfe212516f0023-pr-67
arm64v8-e48542ca-pkg-e48542ca-dev-8c36a7a608c56c8b6c9533d9d2cfe212516f0023-pr-67

Copy link
Member

@Roxedus Roxedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a need for the empty option?

@nemchik
Copy link
Member Author

nemchik commented Nov 19, 2023

is there a need for the empty option?

Yes. The empty option keeps the default behavior: using duckdns to detect the IPv4 rather than using a 3rd party service, which is used when the value is set to ipv4 (or anything other than blank)

@Roxedus Roxedus merged commit e319306 into master Nov 19, 2023
7 checks passed
@Roxedus Roxedus deleted the unraid-options branch November 19, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants