Documentation: assign-collaboration: Fix typo #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
reviewed
Apr 10, 2024
| @@ -121,7 +121,7 @@ Follow the seven rules of writing a good commit message: https://cbea.ms/git-com | |||
| Add `TODOs` with each team member tasks. Try to split the work evenly. | |||
|
|
|||
There was a problem hiding this comment.
@hanyujie2002 for next patches can you please also your Signed-off-by line?
There was a problem hiding this comment.
@hanyujie2002 for next patches can you please also your Signed-off-by line?
Sorry, the Linux repo is too huge, which causes me finding myself reluctant to clone this repo on my personal computer. So I make commits directly on GitHub, which makes signing-off impossible.
There was a problem hiding this comment.
So, when you create commit directly on github isn;t possible to add by hand:
Signed-off-by: First Name Last Name
in your commit message?
This sounds strange.
How do you add the commit subject then?
There was a problem hiding this comment.
On, I see. Thanks for your instruction. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.