Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm chart, make RBAC optional, add Service #354

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

multimac
Copy link

@multimac multimac commented Jul 1, 2021

I've got some additional changes to the Helm chart for Chaoskube.

Changes

  • Made the ClusterRole and ClusterRoleBinding optional by setting rbac.create to false
  • Added a Service which can be created and configured via chaoskube.service
  • Added ability to configure additional pod labels via podLabels

Copy link

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a ServiceMonitor as well?


spec:
type: {{ .Values.chaoskube.metrics.service.type }}

Copy link

@mkilchhofer mkilchhofer Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding blank lines here (L9, L12, L18)?

What about adding clusterIP: None by default (headless service)? Normally we don't need a ClusterIP for metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants