Faucet has a chain listener #2410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
reviewed
Sep 6, 2024
ma2bd
reviewed
Sep 6, 2024
christos-h
force-pushed
the
faucet-subscriber-2
branch
3 times, most recently
from
42e5b5f
to
71aea89
Compare
Twey
reviewed
Sep 18, 2024
CLI.md
Outdated
| @@ -100,7 +100,7 @@ A Byzantine-fault tolerant sidechain with low-latency finality and high throughp | |||
| * `--recv-timeout-ms <RECV_TIMEOUT>` — Timeout for receiving responses (milliseconds) | |||
|
|
|||
| Default value: `4000` | |||
| * `--max-pending-message-bundles <MAX_PENDING_MESSAGE_BUNDLES>` — The maximum number of incoming message bundles to include in a block proposal | |||
There was a problem hiding this comment.
Is this an accidental regression?
There was a problem hiding this comment.
Ah good catch. I think I may need a rebase.
There was a problem hiding this comment.
@christos-h: You can run:
cargo run --locked --bin linera help-markdown > CLI.md(That will probably just revert the file, but it makes sure it's in sync with the code.)
Comment on lines
+80
to
+96
| let faucet_client = net.make_client().await; | ||
| faucet_client.wallet_init(&[], FaucetOption::None).await?; | ||
|
|
||
| let faucet_chain = client | ||
| .open_and_assign(&faucet_client, Amount::from_tokens(1_000u128)) | ||
| .await?; | ||
|
|
||
| let mut faucet_service = faucet_client | ||
| .run_faucet(None, faucet_chain, Amount::from_tokens(2)) | ||
| .await?; | ||
|
|
||
| faucet_service.ensure_is_running()?; | ||
|
|
||
| let faucet = faucet_service.instance(); | ||
|
|
||
| assert_eq!(faucet.current_validators().await?.len(), 4); | ||
|
|
There was a problem hiding this comment.
The reconfiguration test is already extremely complicated. Does it have to be part of it?
There was a problem hiding this comment.
I didn't want to add another test and increase CI time. Not sure there is a correct answer here.
afck
reviewed
Sep 18, 2024
linera-client/src/chain_clients.rs
Outdated
|
|
||
| pub async fn from_clients(chains: impl IntoIterator<Item = ChainClient<P, S>>) -> Self { | ||
| let chain_clients = Self(Default::default()); | ||
| for chain_client in chains.into_iter() { |
There was a problem hiding this comment.
Suggested change
| for chain_client in chains.into_iter() { | |
| for chain_client in chains { |
| @@ -81,6 +81,14 @@ pub trait ClientContext { | |||
| &mut self, | |||
| client: &ChainClient<Self::ValidatorNodeProvider, Self::Storage>, | |||
| ) -> Result<(), Error>; | |||
|
|
|||
| fn clients(&self) -> Vec<ChainClient<Self::ValidatorNodeProvider, Self::Storage>> { | |||
There was a problem hiding this comment.
Maybe make_clients, to make it clearer that this isn't a (cheap) getter.
CLI.md
Outdated
| @@ -100,7 +100,7 @@ A Byzantine-fault tolerant sidechain with low-latency finality and high throughp | |||
| * `--recv-timeout-ms <RECV_TIMEOUT>` — Timeout for receiving responses (milliseconds) | |||
|
|
|||
| Default value: `4000` | |||
| * `--max-pending-message-bundles <MAX_PENDING_MESSAGE_BUNDLES>` — The maximum number of incoming message bundles to include in a block proposal | |||
There was a problem hiding this comment.
@christos-h: You can run:
cargo run --locked --bin linera help-markdown > CLI.md(That will probably just revert the file, but it makes sure it's in sync with the code.)
christos-h
force-pushed
the
faucet-subscriber-2
branch
from
2771957
to
6d6a13b
Compare
afck
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like the faucet to listen for notifications from the admin change, especially for reconfigurations so that it can automatically update epoch.
Proposal
Add a chain listener to the faucet service. This will work with #2303 so that the faucet only listens for messages from the admin chain.