signals.py: Add notifiers to audit logs

[vincent-olivert-riera]

We had a query for listing notifiers in views.py::AuditList, however, we never registered any logs from signals.py, therefore the result of that query was always empty.

This commit adds the necessary instructions for registering logs when creating, updating or deleting notifiers, so they will appear in the audit logs.

[kfdm]

I think we can't just do this as-is, because Sender can sometimes include sensitive information.

promgen/promgen/models.py

Lines 564 to 579 in f6a00ef

	@classmethod
	def log(cls, body, instance=None, old=None, **kwargs):
	from promgen.middleware import get_current_user
	kwargs["body"] = body
	kwargs["created"] = timezone.now()
	kwargs["user"] = get_current_user()
	if instance:
	kwargs["content_type"] = ContentType.objects.get_for_model(instance)
	kwargs["object_id"] = instance.id
	kwargs["data"] = json.dumps(model_to_dict(instance), sort_keys=True)
	if old:
	kwargs["old"] = json.dumps(model_to_dict(old), sort_keys=True)
	return cls.objects.create(**kwargs)

Audit.log() uses model_to_dict to dump all the information, and we need to ensure the value field can not accidentally be logged.

[vincent-olivert-riera]

I think we can't just do this as-is, because Sender can sometimes include sensitive information.

promgen/promgen/models.py

Lines 564 to 579 in f6a00ef

	@classmethod
	def log(cls, body, instance=None, old=None, **kwargs):
	from promgen.middleware import get_current_user
	kwargs["body"] = body
	kwargs["created"] = timezone.now()
	kwargs["user"] = get_current_user()
	if instance:
	kwargs["content_type"] = ContentType.objects.get_for_model(instance)
	kwargs["object_id"] = instance.id
	kwargs["data"] = json.dumps(model_to_dict(instance), sort_keys=True)
	if old:
	kwargs["old"] = json.dumps(model_to_dict(old), sort_keys=True)
	return cls.objects.create(**kwargs)

Audit.log() uses model_to_dict to dump all the information, and we need to ensure the value field can not accidentally be logged.

According to my tests, when the "alias" field has been populated, that is what is displayed in the logs. Otherwise the value is displayed.

Is that not good enough? If users do not set an alias, I guess we can assume they don't care if the value is displayed.

[kfdm]

Try clicking the 'show' button to see all the details that are stored

[vincent-olivert-riera]

Try clicking the 'show' button to see all the details that are stored

Oh, I didn't check that "Show" button. Thanks!

I fixed that issue in 5df5890.

[kfdm]

LGTM. Rebase and I'll do a final check.

[vincent-olivert-riera]

LGTM. Rebase and I'll do a final check.

Done.