Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix check for invalid annotation name #437

Merged
merged 3 commits into from
Aug 18, 2023

Commits on Aug 16, 2023

  1. Use --buffer for our make test

    By using --buffer, our tests will only show extra output if there is an
    error, which will make our normal test results easier to read.
    kfdm committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    66bb104 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Reorder rule label/annotation checks.

    We need to ensure that our labels and annotations are also evaluated
    when we call promtool to validate our rules.
    kfdm committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    02b18fc View commit details
    Browse the repository at this point in the history
  2. Minor change to promtool check output

    By telling our subprocess that we want the encoding as utf8, we can save
    an extra decode step. We also reorder the output a bit to show the
    promtool output first.
    kfdm committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f773e29 View commit details
    Browse the repository at this point in the history