Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Rule label/annotation storage to JsonField #427

Merged
merged 1 commit into from
Jul 18, 2023

Commits on Jul 13, 2023

  1. Convert Rule label/annotation storage to JsonField

    When Promgen was written, there was not a default JsonField, so labels
    and annotations were implemented as a class. Now that JsonField has been
    in Django since 3.1, it's a good time to change the implementation.
    
    Previously, our audit log did *not* store change to labels/annotations
    (because they were separate objects), so one benefit of this migration
    is that those changes now show up in the edit log.
    
    We also expect some queries to be a bit faster now that we do not need
    to query the other table relations for labels/annotations.
    kfdm committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f48218e View commit details
    Browse the repository at this point in the history