Draw a grid and test it #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete function to draw a square grid. Adds several helper functions for taking an initial element and shifting it a certain amount a certain number of times. Co-authored-by: Preben Ingvaldsen <[email protected]>
The grid drawing function involves enough code that it should be its own file. We attempted writing clojurescript tests first, but we can make the grid file compile for just clojure if we pass in window height and width to the function, which we should be doing anyways. But, since setting up the clojurescript tests wasn't quite trivial, this commit exists as a proof of concept showing how to do it if the grid namespace was cljs. I'll be removing the cljs versions after this commit since we don't actually want them, but we may want something like this in the future. The "testing" part of the boot invocation is like a "with-profile test" in lein, although I'm a fan of just constructing a custom task to do that, I have no reason to run the test tasks without adding the test/ directory to source paths. I do wonder if there is a way to get the test runner to ignore src/ files, since they won't contain tests, but I assume removing src/ from source-paths will break things. It's not a big deal right now though, just results in extra output. Co-authored by: lindboe <none>
|
@PastelMobileSuit would be helpful to have another set of eyes to make sure I didn't mess anything up in the rebasing. This is still a bit unpolished but I thought it'd be good to get it into master since it's been sitting for a bit. |
PastelMobileSuit
approved these changes
Jul 14, 2018
README.md
Outdated
| To run the clojure tests, run `boot testing test`. (The "testing" part adds the | ||
| test/ directory to the source paths.) | ||
|
|
||
| To run clojurescript tests, run `boot testing test-cljs`. |
There was a problem hiding this comment.
It looks like this was missed when the cljs testing stuff was removed
Removing the cljs testing examples because they're not actually needed code, I just left them in the commit history for future reference.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers adding functions to create line elements to pass to the render function such that a grid is drawn. It also adds tests for those grid functions.