Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lincbrain WebKNOSSOS upstream sync #15

Open
wants to merge 173 commits into
base: master
Choose a base branch
from
Open

Conversation

aaronkanzer
Copy link

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • abc

TODOs:

  • ...

Issues:

  • fixes #

(Please delete unneeded items, merge only when none are left open)

hotzenklotz and others added 30 commits June 12, 2024 15:19
* make login, registration and forgot password view more responsive to mobile devices
- includes adding a link back to login for password reset view

* make dashboard dataset view less awful

* add changelog entry
* allow viewing a mapping

* WIP: enable setting default active mappings in default view configuration

* add default active mapping to default view configuration
- add config settings to dataset settings default view config tab
- auto load initial default mapping

* fix bottom margin of layer settings
- was broken in view mode with multiple segmentation layers; the "Save View Config..." Button had no spacing to towards

* fix having the mapping settings enabled for layers with default mapping

* WIP: move default mapping store proeprty to dataset layer config
- undo moving mapping selection to a shared component

* moved default active mapping from separate select to view config layer config
- Also added validation check whether the mapping exists in the dataset view config settings

* allow saving no default active mapping from view mode & model init to new dataset config version

* rename defaultMapping to mapping

* cache available mappings fetched from backend when checking config in dataset settings

* remove logging statements

* clean up

* add changelog entry

* apply pr feedback
* fix animation modal color layer validation

* changelog

* rename variable

* apply pr feedback

* improve error message of uint24 layers in animation modal

---------

Co-authored-by: Michael Büßemeyer <[email protected]>
* validate BB size to be larger then 0

* changelog

* appy PR feedback
* default state wording to indicate loading

* update nml tests

---------

Co-authored-by: Michael Büßemeyer <[email protected]>
* Remove suggestion route

* Remove WKWDataFormat

* Lint

* wip remove in frontend

* unify readInboxDataSource

* remove datasource suggestion
- but keep isEditMode prop due to onboarding process needing this prop

* remove left over code line linking to dataset import and clean up code

* remove unused imports in backend

* always show edit settings for datasets the user can edit

* remove unused type

* er-add dataset actions (show error & delete dataset) for broken datasets in dataset table

* adapt wording in messages

* add changelog entry

* update migrationguide,changelog,docs

---------

Co-authored-by: Florian M <[email protected]>
Co-authored-by: Michael Büßemeyer <[email protected]>
Co-authored-by: Florian M <[email protected]>
… split-off segments (scalableminds#7877)

* combine custom names of merged agglomerates & transfer custom name to split off segment

* add changelog entry

* also keep custom name in split from all neighbors action

* Update CHANGELOG.unreleased.md

Co-authored-by: Philipp Otto <[email protected]>

---------

Co-authored-by: Philipp Otto <[email protected]>
…calableminds#7887)

* correctly use base mapping in FullMeshRequest when forwarding from TS to DS

* changelog

---------

Co-authored-by: MichaelBuessemeyer <[email protected]>
…7889)

* Fix dataset composition when only one dataset is used

* update changelog
* WIP: adding unit setting to datasource settings

* WIP: backend: voxel size as object

* WIP: Adding unit to dataset scale [ci skip]
- make keep the base unit internally to nm
- use configured unit for 3d space / voxel space
- WIP: post fix all relevant function with Nm or Vx depending on their unit to make this as explicit as possible

* finish migrating to new datasetscale format [ci skip]

- current state: broken; nothing is rendered

* adjust nml schema to backend changes

* Fix initial dataset loading with scale in mircometers

- add a lot of debugging output for testing [ci skip]

* Fix td viewport camera init ( calulate in datasource unit not always in nm)

- [ci skip]
- Dont ignore far plane calculation

* undo accidental semantic change

* support conversion between larger and smaller units in 1d-3d
- Full support for uncommon units is missing for 2d and 3d

* format 1d length units in datasource unit to avoid precision loss

* WIP: Support formatting for 2d and 3d values without always converting to nm [ci skip]

* unify format function to work with multi dimensional values and not only in 1d && fix lots of tests [ci skip]

* finish writing more tests for format utils

* include all unit format in the datasource json validation in the frontend

* Add support to convert to cm

- WIP: Fix tests now that cm is supported

* Add tests for uncommon units [ci skip]

* rename "datasourceUnit" to "unit" everywhere

* WIP: remove complex tests and add example based tests [ci skip]

* add more format utils tests and fix some tests

* fix / remove introduced todos of this pr

* remove debugging console.logs

* fix datasets e2e test

* redo: use shorter decimals in scalebar

* WIP: voxel unit support backend

* fix vx distance calculation of shortest path between nodes

* improve previous vx length calculation fix

* use voxel size unit in more spots

* schema, evolutions

* snapshots

* rename LengthUnit to Unit in frontend

* further clean up of frontend code

* more code cleanup frontend

* update datasource json frontend validation

* add changelog entry

* log warning in case a mesh is loaded whose scale does not match the dataset's scale

* bump api version to 7, drop 1 and 2

* document that ad-hoc meshing uses voxel size factor only

* unused imports

* WIP: use ngff units during explore

* read ngff voxel size unit during explore

* implement backend pr feedback part 1

* update nml spec snapshot

* report unit in ngff streaming. change composeRequest to expect full voxel size with unit

* format

* unused import

* Fix uploading zipped tiff (should set needsConversion=true)

* changelog

* rephrase code comment

* WIP apply feedback

* Add unit to params of wkw conversion job for dataset upload

* apply pr feedback

* fix adhoc mesh computation

* rename datasetScale to voxelSize in frontend
And remove datasetScale/voxelSize uniform from shaders as it was unused

* power-of-two check on all mag dimensions

* adapt voxelSize to nanometer for worker for now

* use term REST API in changelog after all

* use long lengthUnit names as default format

* snapshots

* migrate frontend to use long unit names except for format utils

* rename UnitShortMap to LongUnitToShortUnitMap

* fix flycam reducer tests

---------

Co-authored-by: Florian M <[email protected]>
Co-authored-by: Florian M <[email protected]>
MichaelBuessemeyer and others added 30 commits September 2, 2024 13:54
* make file paths for reserve upload route optional

* add changelog entry

* apply feedback

---------

Co-authored-by: Michael Büßemeyer <[email protected]>
* updated biome to v1.8

* foo

* fromating?

* fixed remaing biome errors

* format package.json with two spaces

* Update frontend/javascripts/oxalis/controller.tsx

Co-authored-by: Philipp Otto <[email protected]>

---------

Co-authored-by: Philipp Otto <[email protected]>
…s#8046)

* remove vit_l_0b3195_decoder_quantized.onnx

* remove public/images/original

* avoid assets appearing twice in output jars

* remove copy models instruction from webpack
* add warning if opacity is zero

* improve layout, color and icon

* add changelog

* fix typo

* remove exclamation mark

---------

Co-authored-by: Philipp Otto <[email protected]>
* add missing migration to migrations guide

* also fix cloning a tag in ci

* fix syntax
* add new text and application.conf entry

* improve styling

* improve styling when wkorg shouldnt be recommended

* add changelog

* hopefully fix tests and improve check

* remove entry for knossos format

* update snapshots

* fix APIFeatureToggles

* update migration guide

* fix line height

* fix link to commits

* fix link

* stop event propagation for links
* fix layout of buttons in 3d viewport

* fix too large margin in 3d viewport buttons

* tmp: execute nightlies on push

* tmp: only run xyz nightly

* update screenshots for nightly

* zip and upload screenshots for easier download

* fix yaml syntax

* fix yaml syntax

* Revert "tmp: only run xyz nightly"

This reverts commit 43144b9.

* Revert "tmp: execute nightlies on push"

This reverts commit c064579.
* update screenshots

* also bundle screenshots in error case

* naming
…inds#8049)

* swap change color and center BB buttons

* Revert "swap change color and center BB buttons"

This reverts commit 6784852.

* center bbox on click

* fix that clicking any context menu entry centered bbox

* add changelog

* change cursor style for bbox row

* fix that click event and cursor didnt work in padded space of bbox row

---------

Co-authored-by: Philipp Otto <[email protected]>
* add focus bbox to context menu

* focus on click and highlight on hover BBox in move mode

* improve controls for bbox selection in move mode

* improve var naming

* add changelog

---------

Co-authored-by: Philipp Otto <[email protected]>
* updated yarn to version 4

* update readme

* update docker iamge for CI

* create a tmp dir for yarn stuff during asset compilation

* CI?

* replace deprecated yarn --frozen-lock flag with --immutable

* CI?

* CI

* remove yarn caching from CI

* fix CI

* add PR feedback

* add yarn 4.4.1 to docker.dev image
* update libs to react 18.3

* update reactDom to createRoot

* remove antd resolutions in package.json

* update antd to version 5.17.4

* updated redux to v4.0.5

* updated react.router-dom to v5.3.4

* replace react-virtualized with react-virtualized-auto-sizer lib

* replace react-sortable-hoc with dnd-kit 1/2

* replace react-sortable-hoc with dnd-kit 2/2

* fix typescript errors

* updated yarn lock

* updated tanstack/query

* updated tanstack/query

* update flex layout

* update react-json-tree

* fix remaining typescript errors

* mock renderIndenpently in unit tests

* formatting

* fix unit tests

* fix dark mode overwrite for flex layout

* changelog

* apply PR feedback for TS typing

* fix dark mode layer handles

* format
…n update routes (scalableminds#8069)

* add assertion for no duplicated keys in dataset and folder metadata

* format backend

* add changelog entry

* move MetadataAssertions to utils

---------

Co-authored-by: Michael Büßemeyer <[email protected]>
* Script to find json mappings

* skip dot dirs

* add explaining comment

---------

Co-authored-by: MichaelBuessemeyer <[email protected]>
…#8072)

* temporarily disable ci

* disable sbt and target caches

* move commander into new tools/postgres/package.json; copy node_modules in dockerfile

* don't copy node_modules in dockerfile because assetsGenerationTask copies whole postgres folder anyway

* undo changes to docker ignore

* remove last circleci caching as it did more harm than good (reproducibility and performance)

* re-enable ci
Bumps [express](https://github.com/expressjs/express) from 4.18.3 to 4.21.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.18.3...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… enough (scalableminds#7643)

* Do not require binaryData dir to be writable for Compose, orga dir is enough

* don't filter according to ds.allowsUpdate when composing datasets

* unify writable check

* Update webknossos-datastore/app/com/scalableminds/webknossos/datastore/services/DataSourceService.scala

Co-authored-by: Philipp Otto <[email protected]>

---------

Co-authored-by: Philipp Otto <[email protected]>
Co-authored-by: Philipp Otto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants