TW-2064: Fix cancel button in forward screen on web #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
sherlockvn,
hoangdat,
dab246,
hieutbui and
tddang-linagora
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2073 |
hoangdat
approved these changes
Oct 1, 2024
|
please review @KhaledNjim |
hoangdat
deleted the
TW-2064-fix-cancel-button-in-forward-screen-on-web
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Cancelbutton the first time to close the dialog to share media to other messengers #2064Root cause
Navigationto open forward screen, however when click on button cancel usinggo_routerso can't close this screen.Solution
Navigationwhen click on cancel buttonResolved
Screen.Recording.2024-10-01.at.01.08.39.mov
Simulator.Screen.Recording.-.iPhone.15.-.2024-10-01.at.00.42.22.mp4