loopd: allow setting RPC batch size when running cost migration #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we defaulted to fetching 1000 payments at a time when running the cost migration however due to slowness on LND side this may prevent the migration from completing due to RPC timeout kicking in. This commit adds a new config value to give more control to the user by setting the batch size as needed.
|
LGTM, got my loopd back online with this and batch size = 10 ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we defaulted to fetching 1000 payments at a time when running the cost migration however due to slowness on LND side this may prevent the migration from completing due to RPC timeout kicking in. This commit adds a new config value to give more control to the user by setting the batch size as needed.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes