instantout: republish sweepless sweep #745
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the instant out fsm to republish the sweep transaction if we restart loop.
hieblmi
reviewed
Aug 8, 2024
| } | ||
|
|
||
| // PublishSweeplessSweepAction publishes the sweepless sweep transaction. | ||
| func (f *FSM) PublishSweeplessSweepAction(eventCtx fsm.EventContext) fsm.EventType { |
There was a problem hiding this comment.
_ fsm.EventContext fixes lll
| OnPreimagePushed = fsm.EventType("OnPreimagePushed") | ||
| // OnSweeplessSweepBuilt is the event that is triggered when the preimage | ||
| // is pushed to the server and the sweepless sweep tx has been built. | ||
| OnSweeplessSweepBuilt = fsm.EventType("OnPreimagePushed") |
| fsm.OnError: Failed, | ||
| OnErrorPublishHtlc: PublishHtlc, | ||
| OnRecover: PushPreimage, | ||
| OnSweeplessSweepBuilt: PublishSweeplessSweep, |
There was a problem hiding this comment.
I think it is cleaner if we extract the sweepless sweep tx creation from PushPreiamgeAction to PublishSweeplessSweepAction and then rename the transition OnSweeplessSweepBuilt to OnPreimagePushed.
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the instant out fsm to republish the sweep transaction if we restart loop.
This is in draft state, as we also need to republish the sweepless sweep should a new block come in.