Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt to fix #449 (ECDSA forcing DER/ASN.1) #450

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

karel-m
Copy link
Member

@karel-m karel-m commented Oct 14, 2018

This PR is incomplete (as I am not sure if it is the proper fix).

Cc: @sjaeckel @rmw42

TODO:

  • update doc
  • add a test case with eth27 signature format

Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pk/ecc/ecc_sign_hash_rfc7518.c Show resolved Hide resolved
@sjaeckel
Copy link
Member

so we wait now until the two missing points are done?

@karel-m
Copy link
Member Author

karel-m commented Apr 10, 2019

If you agree with the proposed split, which I assume you do, I (or any other volunteer) have to update doc and tests.

@sjaeckel
Copy link
Member

👍

@karel-m karel-m force-pushed the pr/ecdsa-der-attempt1 branch 2 times, most recently from 797f10c to 9340721 Compare June 12, 2019 08:58
@sjaeckel sjaeckel added this to the next milestone Oct 26, 2020
karel-m and others added 7 commits April 11, 2021 16:39
via e.g.

```
make -j9 EXTRALIBS="../libtommath/libtommath.a " \
	CFLAGS="-DLTC_NOTHING -DLTC_MINIMAL -DLTC_MECC -DUSE_LTM \
	-DLTM_DESC -I../libtommath"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants