Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused deps #1352

Merged
merged 1 commit into from
Sep 30, 2024
Merged

remove unused deps #1352

merged 1 commit into from
Sep 30, 2024

Conversation

kingosticks
Copy link
Contributor

@kingosticks kingosticks commented Sep 25, 2024

I think there are more than this but these stood out to me, and I caused one of them (rpassword).

@yubiuser
Copy link
Contributor

There might be even more...

/workspaces/librespot # cargo machete
Analyzing dependencies of crates in this directory...
cargo-machete found the following unused dependencies in this directory:
librespot-protocol -- ./protocol/Cargo.toml:
        protobuf
librespot -- ./Cargo.toml:
        rpassword
        webpki
librespot-discovery -- ./discovery/Cargo.toml:
        cfg-if
librespot-audio -- ./audio/Cargo.toml:
        byteorder
        futures-core
librespot-metadata -- ./metadata/Cargo.toml:
        byteorder
librespot-playback -- ./playback/Cargo.toml:
        byteorder
        glib
        

@kingosticks
Copy link
Contributor Author

If you try removing protobuf from librespot-protocol it doesn't end very well. That tool is limited. But the others look sensible and seems to build.

@roderickvd roderickvd merged commit b1180fb into librespot-org:dev Sep 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants