fix error when time is None

libkeepass · Jun 5, 2023 · 2f63ad8 · 2f63ad8
1 parent f3da333
commit 2f63ad8
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 4 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,4 +1,10 @@
-4.0.4 -
+4.0.5 -
+------------------
+- fixed #344 - AttributeError when accessing Times with None value
+- use __hash__ when evaluating equality
+- use mtime/uuid for HistoryEntry hashing
+
+4.0.4 - 2023-05-23
 ------------------
 - fixed #314 - correctly handle binaries with no data
 - fixed #265 - check for keepass signature
@@ -10,8 +16,8 @@
 
 4.0.3 - 2022-06-21
 ------------------
-- add otp support
-- add debug_setup() function
+- added otp support
+- added debug_setup() function
 
 4.0.2 - 2022-05-21
 ------------------

diff --git a/pykeepass/baseelement.py b/pykeepass/baseelement.py
@@ -93,7 +93,7 @@ def _get_times_property(self, prop):
         times = self._element.find('Times')
         if times is not None:
             prop = times.find(prop)
-            if prop is not None:
+            if prop is not None and prop.text is not None:
                 return self._kp._decode_time(prop.text)
 
     def _set_times_property(self, prop, value):

diff --git a/tests/test3.kdbx b/tests/test3.kdbx
diff --git a/tests/test4.kdbx b/tests/test4.kdbx
diff --git a/tests/tests.py b/tests/tests.py
@@ -960,6 +960,11 @@ def test_issue308(self):
 
         self.assertEqual(results, results2)
 
+    def test_issue344(self):
+        # accessing expiry_time throws exception when None
+
+        e = self.kp.find_entries(title='none_date', first=True)
+        self.assertEqual(e.expiry_time, None)
 
 class EntryFindTests4(KDBX4Tests, EntryFindTests3):
     pass