Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Cases for UE Generation Handler #11

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Test Cases for UE Generation Handler #11

wants to merge 21 commits into from

Conversation

WaterMenon09
Copy link
Contributor

Introduction

This PR introduces a suite of test cases for the UE Generation Handler to ensure the accuracy and reliability of the mobility data generation process. The tests cover various aspects including the conversion of XY coordinates to geographic coordinates, the integrity of the DataFrame structure, and the consistency of data across multiple batches and ticks.

Test Details

  • Test Conversion Accuracy: Validates that the XY to longitude/latitude conversion aligns with expected geographical mappings.
  • DataFrame Structure Verification: Ensures that the DataFrame contains the correct columns (mock_ue_id, longitude, latitude, tick) and that data types are appropriately assigned.
  • Batch and Tick Consistency: Checks that data is consistent across different batches and ticks, ensuring no data leakage or misalignment occurs.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 17, 2024 •
edited
Loading

CLA Not Signed

paulvarkey
paulvarkey requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@paulvarkey paulvarkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Feel free to add CLI command in the description that specifies how to run the tests
  2. Add docstrings in each test (your PR description is quite nice -- those same comments may appear as docstrings here)

radp/digital_twin/mobility/tests/test_UETracksGenerationHelper.py Outdated
Comment on lines 72 to 75
'''
if __name__ == '__main__':
unittest.main()
'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may delete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the redundant comments, added the docstring and added the CLI code to run in the docstring under
"How To Run"

radp/digital_twin/mobility/tests/test_UETracksGenerationHelper.py Outdated
@@ -0,0 +1,75 @@
import unittest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename file as test_ue_tracks_generation_helper.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulvarkey paulvarkey paulvarkey requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WaterMenon09 @paulvarkey @tanzim10