Skip to content

Commit

Permalink
fix: fixing bazel bep name generation for qualification (dfinity#1747)
Browse files Browse the repository at this point in the history
This PR aims to fix the issues that have been occurring in the CI with
issue in race conditions in uploading the same file from different
matrix jobs.

---------

Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
  • Loading branch information
NikolaMilosa authored and levifeldman committed Oct 1, 2024
1 parent b82e636 commit a4d1146
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 5 additions & 1 deletion .github/workflows-source/release-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ anchors:
# we avoid collecting artifacts of jobs that were cancelled
if: success() || failure()
uses: actions/upload-artifact@v4
with:
with: &bazel-bep-with
name: ${{ github.job }}-bep
retention-days: 14
if-no-files-found: ignore
Expand Down Expand Up @@ -202,3 +202,7 @@ jobs:
BAZEL_EXTRA_ARGS_RULES: "--test_timeout=7200 --test_env=OLD_VERSION=${{ matrix.version }}"
HONEYCOMB_API_TOKEN: ${{ secrets.HONEYCOMB_API_TOKEN }}
- <<: *bazel-bep
name: Upload bazel bep for version ${{ matrix.version }}
with:
<<: *bazel-bep-with
name: ${{ github.job }}-${{ matrix.version }}-bep
6 changes: 3 additions & 3 deletions .github/workflows/release-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -280,16 +280,16 @@ jobs:
BAZEL_CI_CONFIG: "--config=systest --repository_cache=/cache/bazel"
BAZEL_EXTRA_ARGS_RULES: "--test_timeout=7200 --test_env=OLD_VERSION=${{ matrix.version }}"
HONEYCOMB_API_TOKEN: ${{ secrets.HONEYCOMB_API_TOKEN }}
- name: Upload bazel-bep
# runs only if previous step succeeded or failed;
- # runs only if previous step succeeded or failed;
# we avoid collecting artifacts of jobs that were cancelled
if: success() || failure()
uses: actions/upload-artifact@v4
name: Upload bazel bep for version ${{ matrix.version }}
with:
name: ${{ github.job }}-bep
retention-days: 14
if-no-files-found: ignore
compression-level: 9
path: |
bazel-bep.pb
profile.json
name: ${{ github.job }}-${{ matrix.version }}-bep

0 comments on commit a4d1146

Please sign in to comment.