Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFE: Remove support for draft-ietf-acme-ari01 CertID format #7448

Merged
merged 3 commits into from
May 10, 2024

Conversation

beautifulentropy
Copy link
Member

Fixes #7183

@beautifulentropy beautifulentropy marked this pull request as ready for review April 23, 2024 20:40
@beautifulentropy beautifulentropy requested a review from a team as a code owner April 23, 2024 20:40
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the wholesale removal of the integration test.

test/integration/ari_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged main to triple-check that the changes to the ari integration test were identical, and yep, that file disappeared entirely from this diff. LGTM

@pgporada pgporada merged commit 10b7e63 into main May 10, 2024
12 checks passed
@pgporada pgporada deleted the deprecate-ari-draft-01 branch May 10, 2024 18:54
vbaranovskiy-plesk pushed a commit to plesk/boulder that referenced this pull request May 30, 2024
AlinaADmi pushed a commit to plesk/boulder that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WFE: Remove support for draft-ietf-acme-ari01 CertID from RenewalInfo and UpdateRenewal methods
3 participants