Skip to content

Commit

Permalink
Run config/sql change action when ready for review (#7419)
Browse files Browse the repository at this point in the history
Rather than running the "check-changes" action immediately when a PR is
opened, wait for the PR to be ready for review (either by being taken
out of draft mode, or by having reviewers added). This way it's possible
to create a draft PR, then create a corresponding deployment ticket
which references the PR, add that ticket to the PR description, and mark
the PR ready for review, thereby pre-empting the bot so it doesn't have
to leave a comment.
  • Loading branch information
aarongable committed Apr 10, 2024
1 parent ebdabe6 commit 2099d57
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/issue-for-sre-handoff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Check PR for configuration and SQL changes

on:
pull_request:
types: [opened, synchronize, reopened]
types: [ready_for_review, review_requested]
paths:
- 'test/config-next/*.json'
- 'test/config-next/*.yaml'
Expand Down

0 comments on commit 2099d57

Please sign in to comment.