[TTGO Display] Plugin for TTGO Display

[kretzp]

[TTGO Display] Plugin for TTGO Display tu use the on board display

[kretzp]

I wrote a Plugin for TTGO DUisplay based on your Plugin Plugin 095: ILI9341 TFT 2.4inches display

[tonhuisman]

The ST77xx series of TFT chips is already supported via plugin P116, in PR #3761, without pulling in the massive and inflexible (compile-time configuration) eTFT library...
And also, plugin ID P126 is already reserved for the FT6206 touch controller, as can be seen in (pinned) issue #3839

Edit:
And via #3903 support for other ILI934x and ILI948x TFT is made available by extending P095.

[TD-er]

Not sure what to think about this PR.
The code in P126_data_struct.h does look so familiar, that even the comments make me think a lot of it is a copy/paste from another plugin.

This also means that the code to decode commands has a lot of overlap with existing code, thus increasing the build size as it cannot be re-used.

I leave it to Ton to look into this, as he's also been working a lot on the (pending) PRs for other displays.

[tonhuisman]

I can only suggest to drop this PR, as it is, as stated in the OP, a carbon copy of P095, reworked for the TTGO unit, that was even used for bug-fixing of the P116 code, starting here, implying that this is not a feasible PR.
Another red flag is the use of the TFT_eSPI library, that is fine for any Arduino, single purpose, implementation, but 'less suitable' for integration in ESPEasy, as it is configured by handcrafting .h files, and recompiling.

The duplication of the command handling I mitigated by implementing the AdaGFX_Helper, that processes the commands for P116, P095 and P096, and can handle any new display plugin that is based on Adafruit_GFX. It also de-duplicates most of the settings on the Device configuration page, that otherwise would have to be repeated for each display plugin.

[TD-er]

Closing as it is essentially a duplicate of a pending PR: #3761
Also the chosen library is very hard to use in ESPEasy, as Ton mentioned, since the library needs to use defines at compile time to setup parameters.

[kretzp]

OK, I didn't see, that you are already working on P116. If you don't mind i will test #3761 with my TTGO Display and give you feedback...