Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar/Togglebar availability issue resolved #358

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

Muhammed-Moinuddin
Copy link
Contributor

Description
On running this repo on local host I faced:

moin@pc:~/Documents/Github/getnighthawk/docs$ make site  
bundle exec jekyll serve --drafts --livereload --config _config.yml  
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.  
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.  
Configuration file: /home/moin/Documents/Github/getnighthawk/docs/_config.yml  
Source: /home/moin/Documents/Github/getnighthawk/docs  
Destination: /home/moin/Documents/Github/getnighthawk/docs/_site  
Incremental build: disabled. Enable with --incremental  
Generating...  
Jekyll Feed: Generating feed for posts  
Liquid Exception: undefined method `tainted?' for nil:NilClass in /home/moin/Documents/Github/getnighthawk/docs/collections/_pages/about.html  
------------------------------------------------  
Jekyll 4.1.1 Please append `--trace` to the `serve` command  
for any additional information or backtrace.  
------------------------------------------------  
/usr/share/rvm/gems/ruby-3.2.2/gems/liquid-4.0.3/lib/liquid/variable.rb:124:in `taint_check': undefined method `tainted?' for nil:NilClass (NoMethodError)

return unless obj.tainted?  
^^^^^^^^^  
from /usr/share/rvm/gems/ruby-3.2.2/gems/liquid-4.0.3/lib/liquid/variable.rb:89:in `render'

I searched the issue and updated library named : liquid by running command bundle update liquid after which I was successfully able to run it locally:

moin@pc:~/Documents/Github/getnighthawk/docs$ make site
bundle exec jekyll serve --drafts --livereload --config _config.yml
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Configuration file: /home/moin/Documents/Github/getnighthawk/docs/_config.yml
            Source: /home/moin/Documents/Github/getnighthawk/docs
       Destination: /home/moin/Documents/Github/getnighthawk/docs/_site
 Incremental build: disabled. Enable with --incremental
      Generating... 
       Jekyll Feed: Generating feed for posts
                    done in 1.164 seconds.
 Auto-regeneration: enabled for '/home/moin/Documents/Github/getnighthawk/docs'
LiveReload address: http://127.0.0.1:35729
    Server address: http://127.0.0.1:4000
  Server running... press ctrl-c to stop.

Which automatically resolved Navbar/Togglebar availability issue, see attached SS for reference.

resolve2
resolve-1

So the issue was with the library, and after updating it, the issue is resolved.

This PR fixes #357

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jun 2, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Jun 2, 2024

Website preview ready!

Name Link
🔨 Latest commit 7847c6b
🔍 Latest deploy log https://app.netlify.com/sites/getnighthawk/deploys/665f21c19ffac20009bce73b
😎 Deploy Preview https://deploy-preview-358--getnighthawk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member

@Muhammed-Moinuddin Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

Copy link

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MUzairS15 MUzairS15 merged commit 9bfc3d3 into layer5io:master Jun 6, 2024
5 of 7 checks passed
Copy link

welcome bot commented Jun 6, 2024

Thanks for your contribution to the Layer5 community! 🎉

Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Navbar/Togglebar is not available in Tablet or Mobile mode.
4 participants