UTC date in zip archive #361
Conversation
|
I'm not sure this makes sense: if the package date is ahead of the local date when you build docs, it could well fail. |
jlaurens
changed the title
|
What is the link between the |
|
For example when |
|
Comparing times (or dates) in possibly different time zones gives undefined result, if you don't know the time zones in advance. |
jlaurens
changed the title
| local concat = table.concat | ||
| local open = io.open | ||
| local osdate = os.date | ||
| local pack = string.pack | ||
| local concat = table.concat | ||
| local open = io.open | ||
| local os_date = os.date | ||
| local os_time = os.time | ||
| local pack = string.pack | ||
| local setmetatable = setmetatable | ||
| local iotype = io.type | ||
| local iotype = io.type |
There was a problem hiding this comment.
Not really seeing the need for this but at the same time I have no strong objection
| local t = osdate('*t', unix) | ||
| local t = os_date('!*t', unix) |
There was a problem hiding this comment.
This one is a job of @zauguin
|
Not sure why this is closed, but I don't have strong opinions on this. I'm weakly in favor of the change, but I'm guessing we should ask CTAN what they usually assume the times to mean in uploads. |
|
The libzip documentation is very clear on the subject. |
The libzip file you linked only documents The function you propose to change is for the legacy timestamps. Their specification in APPNOTE says:
I wouldn't refer to UTC as a "time format" but in any case it explicitly does not specify UTC for these. Also MS-DOS times are traditionally in the local timezone. |
|
Thanks for the clarification. |
avoid local date in tagging.
It assumes that the
os.dateis not buggy.Fix a bug in l3build-zip