Skip to content

Commit

Permalink
Extend version string normalisation (see #96)
Browse files Browse the repository at this point in the history
  • Loading branch information
josephwright committed Sep 11, 2023
1 parent d7e58d9 commit 8e76224
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ this project uses date-based 'snapshot' version identifiers.
### Added
- Document ConTeXt as supported `checkformat`

### Changed
- Extend version string normalisation during checks
(see issue \#96)

## [2023-09-07]

### Changed
Expand Down
3 changes: 3 additions & 0 deletions l3build-check.lua
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ local function normalize_log(content,engine,errlevels)
-- Deal with dates
if match(line, "[^<]%d%d%d%d[/%-]%d%d[/%-]%d%d") then
line = gsub(line,"%d%d%d%d[/%-]%d%d[/%-]%d%d","....-..-..")
-- Classical LaTeX version strings
line = gsub(line,"v%d+%.?%d?%d?%w?","v...")
-- Semantic version-like ones
line = gsub(line,"v%d+%.%d+%.%d+[%d%a.+%-]*","v...")

This comment has been minimized.

Copy link
@zepinglee

zepinglee Sep 11, 2023

Perhaps this line should be placed before classical LaTeX version. For example, v0.4.3 is converted to v....3 in above classical LaTeX substitution and then it fails to match the SemVer pattern.

end
-- Deal with leading spaces for file and page number lines
line = gsub(line,"^ *%[(%d)","[%1")
Expand Down

0 comments on commit 8e76224

Please sign in to comment.