feat: Support scoping jackett searches with filter #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created new setting for jackett that allows specifying a [filter-index](https://github.com/Jackett/Jackett?tab=readme-ov-file#filter-indexers) when not set will default to `all` leaving current behavior in place. * Updated initial migrations to include new `nefarious_settings.jackett_filter_index` * Updated `verify_settings_jackett` to include the set `nefarious_settings.jackett_filter_index` during verification * Updated `get_jackett_search_url` to return with the current `nefarious_settings.jackett_filter_index` used. Issue: [Fixes Issue #292](#292)
* Installing pip 24.0 to avoid build failure see [pypa/pip#12063](pypa/pip#12063) * FIxes Issue #294 Issue: #294
* Updated the UI to show the filter-index label * Added link to documentation for filter-index for the label. * Re ran migration to recreate after updates and deleted previous one. Fixes: Issue #292
disaac
changed the title
This was referenced Jul 1, 2024
|
I'm excited to see all your contributions! I'm away all this week on
holiday so I'll get up to speed late next week. Thanks
…On Mon, Jul 1, 2024, 9:36 AM Daniel ***@***.***> wrote:
Fixes Issue #292 <#292> works
around issue #294 <#294> until
updated to support pip > 24.0. Should be Ready for merge as is.
—
Reply to this email directly, view it on GitHub
<#297 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKYIKNF7UJBO3AE25NFYWV3ZKGAQHAVCNFSM6AAAAABKF4AB46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGU4TKMRRGI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
This looks good and works well for me. I made some minor/cosmetic changes. |
lardbit
deleted the
disaac/fixes-issue-292-add-jackett-filter-index-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Support scoping jackett searches with filter
allleaving current behavior in place.nefarious_settings.jackett_filter_indexverify_settings_jackettto include the setnefarious_settings.jackett_filter_indexduring verificationget_jackett_search_urlto return with the currentnefarious_settings.jackett_filter_indexused.Issue: Fixes Issue https://github.com/lardbit/nefarious/issues/292
chore: Lock in pip to version 24.0
Issue: #294
fix: Updating UI / Recreate migration
Fixes: Issue #292
Related chore issues: Issue #294 and Issue #296