For updating to python 3.9 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ammaraskar/sphinx-action only supports Python 3.8, switch to actions/setup-python@v5 to use Python 3.9 2. Bump actions/checkout to v4 3. Bump actions/upload-artifact to v4
|
Should be good now. It seems sphinx will return 0 even if something is wrong, like the problem we got before the fix. sphinx-doc/sphinx#10397 We do have some warnings, so we cannot simply treat all warnings as errors. There might be a way to have sphinx returns non-zero in this case, so that the existing docs are not overwritten at least. I will take a look at this later. |
|
Very nice @tautomer ! |
* removed no longer used package imports * Update Python version requirement to >=3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion issue for this PR: #55