Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the documentation and examples for hyperparameter tuning #103

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

tautomer
Copy link
Collaborator

The doc part is done, but I have not added the full example script yet.

@tautomer tautomer added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2024
@tautomer tautomer marked this pull request as draft September 18, 2024 00:03
@tautomer tautomer closed this Sep 18, 2024
@tautomer tautomer reopened this Sep 18, 2024
@tautomer tautomer marked this pull request as ready for review September 18, 2024 20:56
@tautomer tautomer changed the title [WIP] Add the documentation for hyperparameter tuning Add the documentation for hyperparameter tuning Sep 18, 2024
@tautomer tautomer changed the title Add the documentation for hyperparameter tuning Add the documentation and examples for hyperparameter tuning Sep 18, 2024
@tautomer
Copy link
Collaborator Author

Apart from some typos here and there (I'm pretty there are plenty of them is the tutorial), the PR should be ready.

Sakib wrote the original sequential script and shared to me, so I think I should give him some credits. What's the best way?

@lubbersnick
Copy link
Collaborator

This is really cool! re: attribution, feel free to put your names in the docstring for example scripts and also, if you desire, the documentation files. e.g. "Contributed by: person (insitution), person (institution)" or something.

Also, to check for my own understanding, it appears there is not a lot of reason for us to add any functions into hippynn itself, because ray/ax already operate on a fairly black-box level. As such we also don't need to add these as optional dependencies. Is that right?

@tautomer
Copy link
Collaborator Author

This is really cool! re: attribution, feel free to put your names in the docstring for example scripts and also, if you desire, the documentation files. e.g. "Contributed by: person (insitution), person (institution)" or something.

Great. I will for sure add Sakib and me, mainly for him to get the proper credits.

Also, to check for my own understanding, it appears there is not a lot of reason for us to add any functions into hippynn itself, because ray/ax already operate on a fairly black-box level. As such we also don't need to add these as optional dependencies. Is that right?

You are totally right. Just need some fairly small changes to the existing training scripts. We do not have to add them as the optional dependencies.

1. Fix typos
2. Improve the warning message display
3. Add authors
@tautomer
Copy link
Collaborator Author

@lubbersnick I have fixed some typos and add our names to the scripts and docs, but I could not push the commit due to the LANL internet issue. I will push it once the Internet is back.

@tautomer
Copy link
Collaborator Author

Just pushed the commit.

@tautomer
Copy link
Collaborator Author

@lubbersnick You have to merge it. I don't have the permission.

@lubbersnick
Copy link
Collaborator

@tautomer I know 🙃

@lubbersnick lubbersnick merged commit ddf5ca6 into lanl:development Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants