Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate State Initialization #228

Merged
merged 13 commits into from
Sep 10, 2024
Merged

Automate State Initialization #228

merged 13 commits into from
Sep 10, 2024

Conversation

jacob-moore22
Copy link
Collaborator

@jacob-moore22 jacob-moore22 commented Sep 9, 2024

Description

This PR adds the capability for the solvers to define what state they need and initialize only the required state as well as handle the case when a previous solver already initialized said state. It also adds the start of the staggered grid thermomechanical solver (SGTM), but it is not complete yet. The code currently is valid for that solver up to t=0. The evolution will come in a future PR. Feel free to ignore the SGTM specific files for now.

All solvers have been updated with the new state initialization framework.

As a note, there is still a bit of work to do on automate outputs. We need to add a .get_name() functionality to MATAR arrays to keep from naming the state fields in multiple places. For now, I just added the basic piping to pass the used state to the output writers, but they are not yet used. That will be in a future PR.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A : All regression tests pass on CUDA build.
  • Test B :

Test Configuration:

  • OS version:
  • Hardware:
  • Compiler:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@nathanielmorgan nathanielmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant job with the state enums to declare what state must be allocated. Quite useful stuff!

@jacob-moore22 jacob-moore22 merged commit 27fee63 into main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants