Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modified QdrantVectorStoreComponent to use server_kwargs correctly #3751

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: modified QdrantVectorStoreComponent to use server_kwargs correctly #3751

wants to merge 3 commits into from
+5 −4

Conversation

Swastik-Swarup-Dash
Copy link

resolving#3749

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 10, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 10, 2024
@aws-amplify-sa-east-1 AWS Amplify (sa-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3751.dmtpw4p5recq1.amplifyapp.com

@ogabrielluiz ogabrielluiz linked an issue Sep 16, 2024 that may be closed by this pull request
Qdrant Vector Store doesnt' use the advanced fields when ingesting documents #3749
Open
@ogabrielluiz
Copy link
Contributor

Hey, @Swastik-Swarup-Dash

Thanks for the PR!

Could you update the PR title according to https://www.conventionalcommits.org/en/v1.0.0-beta.2/#summary ?

As soon as you do that we can approve it

@Swastik-Swarup-Dash Swastik-Swarup-Dash changed the title Quadt#3749 fix: Added **server kwargs in line no 92 Sep 16, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 16, 2024
@Swastik-Swarup-Dash Swastik-Swarup-Dash changed the title fix: Added **server kwargs in line no 92 fix:Added **server_kwargs and modified the build_vector_store method in the QdrantVectorStoreComponent fixes issue #3749 Sep 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 16, 2024
@Swastik-Swarup-Dash
Copy link
Author

hey @ogabrielluiz I have updated the PR Tilte

ogabrielluiz
ogabrielluiz approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 16, 2024
@ogabrielluiz ogabrielluiz changed the title fix:Added **server_kwargs and modified the build_vector_store method in the QdrantVectorStoreComponent fixes issue #3749 fix: Added **server_kwargs and modified the build_vector_store method in the QdrantVectorStoreComponent fixes issue #3749 Sep 16, 2024
@ogabrielluiz ogabrielluiz changed the title fix: Added **server_kwargs and modified the build_vector_store method in the QdrantVectorStoreComponent fixes issue #3749 fix: modified QdrantVectorStoreComponent to use server_kwargs correctly Sep 16, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qdrant Vector Store doesnt' use the advanced fields when ingesting documents
2 participants
@Swastik-Swarup-Dash @ogabrielluiz