build(deps): datafusion 41 #2917
Open
+32
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| &context_provider, | ||
| ParserOptions { | ||
| parse_float_as_decimal: false, | ||
| enable_ident_normalization: false, | ||
| support_varchar_with_length: false, | ||
| enable_options_value_normalization: false, // TODOALEX: false or default? |
There was a problem hiding this comment.
Please advise on what value to use here. I figured false given the other options are disabled.
| // See: https://github.com/apache/datafusion/issues/11477 | ||
| for planner in context_provider.state.expr_planners() { | ||
| sql_to_rel = sql_to_rel.with_user_defined_planner(planner.clone()); | ||
| } |
There was a problem hiding this comment.
resolved in apache/datafusion#11485
eddyxu
requested review from
westonpace and
wjones127
and removed request for
westonpace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades datafusion and associated crates to version 41. 42 was just released which also has an arrow update to 53.
We're looking to adopt lance in our service where we've already upgraded to 41 for some other dependencies.