Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow general compression for string and binary types #2877

Closed
wants to merge 1 commit into from

Conversation

niyue
Copy link
Contributor

@niyue niyue commented Sep 13, 2024

This is an attempt to allow users to apply general compression such as zstd to compress string and binary types when they explicitly specify the relevant field metadata

This PR tries to address #2876

… they can be encoded using general compression.
@github-actions github-actions bot added the enhancement New feature or request label Sep 13, 2024
@niyue
Copy link
Contributor Author

niyue commented Sep 13, 2024

Right after submitting the PR, I realized that the relevant code in encoder.rs was significantly updated yesterday, making the PR largely irrelevant 🤣. I'll need some time to review the new code and figure out how the PR should be revised.

@westonpace
Copy link
Contributor

Right after submitting the PR, I realized that the relevant code in encoder.rs was significantly updated yesterday, making the PR largely irrelevant 🤣. I'll need some time to review the new code and figure out how the PR should be revised.

Sorry about that. Yes, some things have been shaking up a bit recently and I do think I disconnected zstd as part of that. My primary goal is to move scheduling out of the lower level "compressive encoders". I do want to reconnect zstd (and friends) as part of 2.1. I'll also look at this a bit today.

@westonpace
Copy link
Contributor

@niyue I've made an attempt in #2878

@niyue
Copy link
Contributor Author

niyue commented Sep 14, 2024

Close this PR in favor of #2878

@niyue niyue closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants