Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cuda/cuvs acceleration for PQ training/assignment #2853

Draft
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

jacketsj
Copy link
Contributor

@jacketsj jacketsj commented Sep 11, 2024

blocked by #2816

Benchmarking ongoing on wikipedia-40M
early tests indicate that cuvs pq params might need some better tuning

Hardware for testing:

  • n1-standard-16
  • nvidia T4

Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@jacketsj jacketsj changed the title cuda/cuvs acceleration for PQ training/assignment feat: cuda/cuvs acceleration for PQ training/assignment Sep 11, 2024
@github-actions github-actions bot added the enhancement New feature or request label Sep 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (c0e1f15) to head (bca8c82).

Files with missing lines Patch % Lines
rust/lance/src/index/vector/ivf.rs 22.22% 5 Missing and 2 partials ⚠️
rust/lance/src/index/vector/ivf/builder.rs 0.00% 3 Missing ⚠️
rust/lance-index/src/vector/ivf/builder.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2853      +/-   ##
==========================================
- Coverage   78.12%   78.09%   -0.04%     
==========================================
  Files         229      229              
  Lines       70492    70497       +5     
  Branches    70492    70497       +5     
==========================================
- Hits        55073    55054      -19     
- Misses      12305    12317      +12     
- Partials     3114     3126      +12     
Flag Coverage Δ
unittests 78.09% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants