Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate MICROBIT_DAL_VERSION and add microbit_dal_version(). #434

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

microbit-carlos
Copy link
Collaborator

@microbit-carlos microbit-carlos commented Jul 9, 2024

This PR required the latest commit from codal-core from PR:

And with these two PRs we can get the following defines and function outputs:

CODAL_VERSION_MAJOR: 0
CODAL_VERSION_MINOR: 2
CODAL_VERSION_PATCH: 66
CODAL_VERSION_HASH: 8c8db00
CODAL_TARGET_NAME: codal-microbit-v2
CODAL_VERSION: 0.2.66
CODAL_VERSION_LONG: 0.2.66+codal-microbit-v2-8c8db00
DEVICE_DAL_VERSION: 0.2.66
MICROBIT_DAL_VERSION: 0.2.66
microbit_dal_version(): 0.2.66
uBit.getVersion(): 0.2.66

Copy link

Build diff

Base commit: 41e7a25544de26ef1682f7ac21edfd0f7b23a7e9
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/9875388569

     VM SIZE    
 -------------- 
  +0.8%     +16    /home/runner/work/codal-microbit-v2/codal-microbit-v2/libraries/codal-core/source/drivers/AnimatedDisplay.cpp
  +0.0%     +16    TOTAL

@lancaster-university lancaster-university deleted a comment from github-actions bot Jul 10, 2024
@microbit-carlos
Copy link
Collaborator Author

As the additions are #defines, and the microbit_dal_version() function is not used in the built samples the "build diff" should have been zero, but because codal-core has been updated, this unrelated bug fix has caused the additional memory consumption:
lancaster-university/codal-core@df05db9

@microbit-carlos microbit-carlos merged commit 9579fab into master Jul 10, 2024
29 checks passed
@microbit-carlos microbit-carlos deleted the dal-ver branch July 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant