Minor cleanup of config flags. #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing #if xxx == 1 to CONFIG_ENABLED, and moving a couple of flags to MicroBitConfig.h
microbit-carlos
commented
Aug 8, 2023
Comment on lines
+299
to
+301
| #ifndef MICROBIT_TRIPLE_RESET_TO_PAIR | ||
| #define MICROBIT_TRIPLE_RESET_TO_PAIR 1 | ||
| #endif |
There was a problem hiding this comment.
Renamed this from DEVICE_TRIPLE_RESET_TO_PAIR to MICROBIT_TRIPLE_RESET_TO_PAIR to follow the current pattern.
Did a GitHub search and there is no usage of this flag outside of this repo (and its forks).
Build diffBase commit: 4f2aedcd8e093e7ca9eefd574d4a647884e82505 |
microbit-carlos
commented
Aug 8, 2023
Comment on lines
-98
to
-100
| // Flag that we have integrate face-touch as a feature | ||
| #define MICROBIT_UBIT_FACE_TOUCH_BUTTON 1 | ||
|
|
There was a problem hiding this comment.
Removed as it is not used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
#if xxx == 1to#if CONFIG_ENABLED(xxx), and moving a couple of flags to MicroBitConfig.h